Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrade #45

Merged
merged 8 commits into from
Feb 25, 2022
Merged

Version upgrade #45

merged 8 commits into from
Feb 25, 2022

Conversation

rigelrozanski
Copy link
Contributor

version upgrade,

@rigelrozanski rigelrozanski requested a review from mpoke as a code owner February 14, 2022 22:21
google.golang.org/protobuf v1.27.1
)

replace (
github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.1-0.20220112185710-fa19ad5f85c5
github.com/cosmos/ibc-go/v3 => github.com/rigelrozanski/ibc-go/v3 v3.0.0-alpha1.0.20220214205135-4e834c9c6adc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be removed and the deps updated once cosmos/ibc-go#917 is merged

Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sainoe added a commit to sainoe/interchain-security that referenced this pull request Feb 22, 2022
- Increment `ValsetUpdateID` once per provider chain block; fix the impacted unit-tests

- Use a reverse iterator to get last  the `ValsetUpdateID` on consumer chains

- Check that slashing packets are sent in the slashing hook unit-tests

- Add acknowledgement boilerplates to the provider chain

- Allow slashing with 0 jail time

- Change the consumer `SendPacket` API to `SendPenalties`

TODO: slashing round-trip tests require a [custom IBC-GO](https://github.com/sainoe/ibc-go/tree/sainoe/valset-update-fixes). This will be sorted out after the cosmos#45 merge.
sainoe added a commit to sainoe/interchain-security that referenced this pull request Feb 22, 2022
- Increment `ValsetUpdateID` once per provider chain block; fix the impacted unit-tests

- Use a reverse iterator to get last  the `ValsetUpdateID` on consumer chains

- Check that slashing packets are sent in the slashing hook unit-tests

- Add acknowledgement boilerplates to the provider chain

- Allow slashing with 0 jail time

- Change the consumer `SendPacket` API to `SendPenalties`

TODO: slashing round-trip tests require a [custom IBC-GO](https://github.com/sainoe/ibc-go/tree/sainoe/valset-update-fixes). This will be sorted out after the cosmos#45 merge.
@rigelrozanski rigelrozanski changed the title DNM: Version upgrade Version upgrade Feb 25, 2022
@rigelrozanski rigelrozanski merged commit 196012a into main Feb 25, 2022
@rigelrozanski rigelrozanski deleted the version-upgrade branch February 25, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants