-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version upgrade #45
Merged
Merged
Version upgrade #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
commented
Feb 14, 2022
google.golang.org/protobuf v1.27.1 | ||
) | ||
|
||
replace ( | ||
github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76 | ||
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.1-0.20220112185710-fa19ad5f85c5 | ||
github.com/cosmos/ibc-go/v3 => github.com/rigelrozanski/ibc-go/v3 v3.0.0-alpha1.0.20220214205135-4e834c9c6adc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to be removed and the deps updated once cosmos/ibc-go#917 is merged
mpoke
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sainoe
added a commit
to sainoe/interchain-security
that referenced
this pull request
Feb 22, 2022
- Increment `ValsetUpdateID` once per provider chain block; fix the impacted unit-tests - Use a reverse iterator to get last the `ValsetUpdateID` on consumer chains - Check that slashing packets are sent in the slashing hook unit-tests - Add acknowledgement boilerplates to the provider chain - Allow slashing with 0 jail time - Change the consumer `SendPacket` API to `SendPenalties` TODO: slashing round-trip tests require a [custom IBC-GO](https://github.com/sainoe/ibc-go/tree/sainoe/valset-update-fixes). This will be sorted out after the cosmos#45 merge.
sainoe
added a commit
to sainoe/interchain-security
that referenced
this pull request
Feb 22, 2022
- Increment `ValsetUpdateID` once per provider chain block; fix the impacted unit-tests - Use a reverse iterator to get last the `ValsetUpdateID` on consumer chains - Check that slashing packets are sent in the slashing hook unit-tests - Add acknowledgement boilerplates to the provider chain - Allow slashing with 0 jail time - Change the consumer `SendPacket` API to `SendPenalties` TODO: slashing round-trip tests require a [custom IBC-GO](https://github.com/sainoe/ibc-go/tree/sainoe/valset-update-fixes). This will be sorted out after the cosmos#45 merge.
rigelrozanski
requested review from
AdityaSripal and
jtremback
as code owners
February 25, 2022 02:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version upgrade,
interchain-security-rebase
branch