-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
47 done jq needs fixed #824
Conversation
taking this PR out of draft so that the automated tests run |
takin out of draft so that ci works |
coming here as this was mentioned in a issue in the sdk. @faddat please stop making general prs, they need to be focused on solving one or a limited amount of things at once. This is very hard to get reviewed and consume more time than you may expect. Please break this pr into smaller prs and make them focused on solving one issue at a time to track the changes better through git history. |
@tac0turtle the ci system here doesn't work unless you have it actually open. 47 upgrades are very general. |
Description
Tests here are kind of a wierd flex.
go calls bash
bash calls jq
and there's replacey stuff in there, and .... it uses gaia v9
this PR would be a draft but CI won't run if it is a draft
Linked issues
Closes:
#<issue>
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature
: Changes and/or adds code behavior, irrelevant to bug fixesFix
: Changes and/or adds code behavior, specifically to fix a bugRefactor
: Changes existing code style, naming, structure, etc.Testing
: Adds testingDocs
: Adds documentationRegression tests
If
Refactor
, describe the new or existing tests that verify no behavior was changed or added where refactors were introduced.New behavior tests
If
Feature
orFix
, describe the new or existing tests that verify the new behavior is correct and expected.Versioning Implications
If the above box is checked, which version should be bumped?
MAJOR
: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)MINOR
: Consensus breaking changes which affect either only the provider or only the consumer(s)PATCH
: Non consensus breaking changesTargeting
Please select one of the following: