Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new API #2

Merged
merged 5 commits into from
Mar 26, 2019
Merged

support new API #2

merged 5 commits into from
Mar 26, 2019

Conversation

jleni
Copy link
Member

@jleni jleni commented Mar 25, 2019

  • getAddress
  • appInfo (provides info about loaded app, version, etc. - works for any loaded app including BOLOS dashboard and third party apps)
  • improved error messages

Related to:
Zondax#15
luniehq/lunie#2299
luniehq/lunie#2298
luniehq/lunie#1962

@jleni jleni requested a review from fedekunze March 25, 2019 14:16
Copy link

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

src/ledger-app.js Show resolved Hide resolved
src/ledger-app.js Outdated Show resolved Hide resolved
src/ledger-app.js Outdated Show resolved Hide resolved
src/ledger-app.js Outdated Show resolved Hide resolved
src/ledger-app.js Outdated Show resolved Hide resolved
src/ledger-app.js Outdated Show resolved Hide resolved
tests/tests-node.js Outdated Show resolved Hide resolved
tests/tests-node.js Outdated Show resolved Hide resolved
tests/tests-node.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
fedekunze and others added 3 commits March 26, 2019 09:43
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
@jleni jleni merged commit ef2dca8 into cosmos:master Mar 26, 2019
@jleni jleni deleted the api branch April 2, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants