Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show address on Ledger #1962

Closed
fedekunze opened this issue Feb 13, 2019 · 4 comments
Closed

Show address on Ledger #1962

fedekunze opened this issue Feb 13, 2019 · 4 comments
Labels
high priority ❗ ledger 👨‍💻 Issues related to Ledger Nano S

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Feb 13, 2019 •
edited
Loading

Description:

need to update the ledger cosmos app

Ref: ledger.showAddress()
@fedekunze fedekunze added the ledger 👨‍💻 Issues related to Ledger Nano S label Feb 13, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 14, 2019

why should we do this?

@faboweb faboweb added the low priority has been discussed, will be addressed later label Feb 24, 2019
@jleni
Copy link
Contributor

jleni commented Feb 25, 2019

Do you need the address to be returned too?
This means that you will need to send the HRP (bech32 human readable part) in the request. Is that acceptable? At the moment, you can retrieve the pubkey and ask the device to show the address in teh screen.

@fedekunze
Copy link
Contributor Author

moved to #2181

@fedekunze fedekunze reopened this Mar 18, 2019
@fedekunze fedekunze changed the title get address directly from Ledger instead from pubkey Show address on Ledger Mar 18, 2019
@fedekunze
Copy link
Contributor Author

@jbibla reopening this as this feature allows you to show the address you have on the Ledger

@fedekunze fedekunze removed the low priority has been discussed, will be addressed later label Mar 18, 2019
@jleni jleni mentioned this issue Mar 25, 2019
Merged
This was referenced May 11, 2019
Closed
Closed
Merged
Closed
@faboweb faboweb mentioned this issue May 18, 2019
Merged
@faboweb faboweb closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority ❗ ledger 👨‍💻 Issues related to Ledger Nano S
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@faboweb @jbibla @jleni @fedekunze