Fabo/2341 better validator updates #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2370 +/- ##
===========================================
+ Coverage 96.42% 96.43% +0.01%
===========================================
Files 106 106
Lines 2376 2383 +7
Branches 129 129
===========================================
+ Hits 2291 2298 +7
Misses 65 65
Partials 20 20
|
Codecov Report
@@ Coverage Diff @@
## develop #2370 +/- ##
===========================================
+ Coverage 96.43% 96.43% +<.01%
===========================================
Files 106 106
Lines 2381 2387 +6
Branches 129 129
===========================================
+ Hits 2296 2302 +6
Misses 65 65
Partials 20 20
|
fedekunze
reviewed
Mar 27, 2019
PENDING.md
Outdated
| @@ -0,0 +1,2 @@ | |||
| [Fixed] Better inplace updates to validators so the information (like signing info) never hides again once it was once loaded @faboweb | |||
|
|
||
| // incrementally add the validator to the list or update it in place | ||
| // "upsert": (computing, databases) An operation that inserts rows into a database table if they do not already exist, or updates them if they do. | ||
| function upsertValidator(state, validator) { |
There was a problem hiding this comment.
nice addition ! this will be way faster with the object refactor
fedekunze
previously approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2341
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: