Fabo/2341 better validator updates

PENDING.md

@@ -1 +1,3 @@
-[Changed] Reduced keybase caching timeouts @faboweb
+[Fixed] [\#2370](https://github.com/cosmos/lunie/pull/2370) Better inplace updates to validators so the information (like signing info) never hides again once it was once loaded @faboweb
+[Fixed] [\#2370](https://github.com/cosmos/lunie/pull/2370) Pages now scroll back to the top on tab changes @faboweb
+[Changed] Reduced keybase caching timeouts @faboweb

app/src/renderer/components/common/TmPage.vue

@@ -114,9 +114,14 @@ export default {
  return refresh ? { connected, refresh } : undefined
  }
  },
+ watch: {
+ $route() {
+ this.scrollContainer.scrollTop = 0
+ }
+ },
  async mounted() {
- const container = this.$el.querySelector(`.tm-page-main`)
- this.perfectScrollbar = new PerfectScrollbar(container)
+ this.scrollContainer = this.$el.querySelector(`.tm-page-main`)
+ this.perfectScrollbar = new PerfectScrollbar(this.scrollContainer)
  }
 }
 </script>

app/src/renderer/vuex/modules/delegates.js

@@ -2,8 +2,9 @@ import * as Sentry from "@sentry/browser"
 import BN from "bignumber.js"
 import { ratToBigNumber } from "scripts/common"
 import num from "scripts/num"
-import { isEmpty } from "lodash"
+import { isEmpty, merge } from "lodash"
 import b32 from "scripts/b32"
+import Vue from "vue"
 
 export default ({ node }) => {
  const emptyState = {
@@ -34,8 +35,9 @@ export default ({ node }) => {
  validator.percent_of_vote = num.percent(
  validator.voting_power / state.globalPower
  )
+
+ upsertValidator(state, validator)
  })
- state.delegates = validators
  },
  setSelfBond(
  state,
@@ -76,7 +78,12 @@ export default ({ node }) => {
  const signing_info = await node.getValidatorSigningInfo(
  validator.consensus_pubkey
  )
- if (!isEmpty(signing_info)) validator.signing_info = signing_info
+ if (!isEmpty(signing_info)) {
+ upsertValidator(
+ state,
+ Object.assign({},validator, { signing_info })
+ )
+ }
  }
  }
  commit(`setDelegates`, validators)
@@ -142,3 +149,20 @@ export default ({ node }) => {
  actions
  }
 }
+
+// incrementally add the validator to the list or update it in place
+// "upsert": (computing, databases) An operation that inserts rows into a database table if they do not already exist, or updates them if they do.
+function upsertValidator(state, validator) {
+ const oldValidatorIndex = state.delegates.findIndex((oldValidator) =>
+ oldValidator.operator_address === validator.operator_address
+ )
+ if (oldValidatorIndex === -1) {
+ state.delegates.push(validator)
+ return
+ }
+ Vue.set(
+ state.delegates,
+ oldValidatorIndex,
+ merge(state.delegates[oldValidatorIndex], validator)
+ )
+}

app/src/renderer/vuex/store.js

@@ -58,7 +58,10 @@ export function storeUpdateHandler(mutation, state, pending) {
  `setProposalDeposits`,
  `setProposalVotes`,
  `setProposalTally`,
- `setGovParameters`
+ `setGovParameters`,
+ `setTotalRewards`,
+ `setDelegationRewards`,
+ `setDistributionParameters`
  ]
 
  if (updatingMutations.indexOf(mutation.type) === -1) return
@@ -156,6 +159,14 @@ export async function loadPersistedState({ state, commit, dispatch }) {
  loaded: true,
  loading: false
  },
+ delegation: {
+ loaded: true,
+ loading: false
+ },
+ distribution: {
+ loaded: true,
+ loading: false
+ },
  proposals: {
  loaded: true,
  loading: false

test/unit/specs/components/common/TmPage.spec.js

@@ -61,4 +61,14 @@ describe(`TmPage`, () => {
  expect(wrapper.vm.refreshable).toEqual({ connected: true, refresh })
  })
 
+ it(`scrolls back to the top on a route change`, () => {
+ const self = {
+ scrollContainer: {
+ scrollTop: 100
+ }
+ }
+ TmPage.watch.$route.call(self)
+ expect(self.scrollContainer.scrollTop).toBe(0)
+ })
+
 })