Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

Use ICS24 to validate all indentifiers #23

Closed
jackzampolin opened this issue Feb 15, 2020 · 1 comment · Fixed by #32
Closed

Use ICS24 to validate all indentifiers #23

jackzampolin opened this issue Feb 15, 2020 · 1 comment · Fixed by #32
Assignees
@zmanian
Labels
blocked help wanted Extra attention is needed UX
Milestone
1.0 Requirements

Comments

@jackzampolin
Copy link
Member

Blocked By: cosmos/cosmos-sdk#5588

The relayer should be able to implement this primarily in the *cobra.Command.Args functions: https://github.com/spf13/cobra#positional-and-custom-arguments

This should help keep the code clean, encourage reuse, and provide more instructive error messages
@jackzampolin jackzampolin added help wanted Extra attention is needed blocked UX labels Feb 15, 2020
@jackzampolin jackzampolin added this to the 1.0 Requirements milestone Feb 15, 2020
@zmanian zmanian self-assigned this Feb 16, 2020
@jackzampolin
Copy link
Member Author

This should be done in the PathEnd.Validate function: https://github.com/cosmos/relayer/blob/master/relayer/chain.go#L190

@jackzampolin jackzampolin mentioned this issue Feb 20, 2020
Merged
jackzampolin pushed a commit that referenced this issue Mar 20, 2020
@jhernandezb
Merge PR #23: Improve run for loop logic and fix lint issues
a4a2aba 
* Improved run loop

* Fixed lint issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zmanian zmanian

Labels
blocked help wanted Extra attention is needed UX
Projects
None yet
Milestone
1.0 Requirements
Development

Successfully merging a pull request may close this issue.

Implement ICS24 Identifier validation cosmos/relayer-archive
2 participants
@zmanian @jackzampolin