Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hitting GH rate limit and clean up logs #1013

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Avoid hitting GH rate limit and clean up logs #1013

merged 8 commits into from
Nov 3, 2022

Conversation

boojamya
Copy link
Contributor

@boojamya boojamya commented Oct 7, 2022

Please ensure this PR is merged first: strangelove-ventures/lens#210

This is meant to avoid hitting the github rate limit when adding many chains to your config.

It also cleans up the log out put.

Note: Rly will still use the github client when using the rly chains registry-list command

Closes: #845, #562

@boojamya boojamya marked this pull request as ready for review October 11, 2022 19:05
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleans up pretty nicely with the changes you made! Great work

cmd/chains.go Outdated Show resolved Hide resolved
@boojamya boojamya merged commit 36f3c1b into main Nov 3, 2022
@boojamya boojamya deleted the dan/getchains branch November 3, 2022 17:00
agouin pushed a commit that referenced this pull request Nov 9, 2022
* clean up chains add

* remove word

* update Lens in mod file

* mod tidy

* mod tidy in ibctest

* handle feedback
agouin pushed a commit that referenced this pull request Nov 15, 2022
* clean up chains add

* remove word

* update Lens in mod file

* mod tidy

* mod tidy in ibctest

* handle feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging when adding chains from chain registry
2 participants