Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate tx broadcast methods #1117

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Consolidate tx broadcast methods #1117

merged 4 commits into from
Mar 10, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Mar 6, 2023 •
edited
Loading

Consolidate SendMessages and SendMessagesToMempool logic.

Fixes missing check for sdk code != 0 errors after broadcast

@agouin agouin force-pushed the andrew/consolidate_cosmos_tx_broadcast branch from 4bb6c02 to e92bd05 Compare March 10, 2023 04:01
@agouin agouin marked this pull request as ready for review March 10, 2023 04:17
jtieri
jtieri approved these changes Mar 10, 2023
View reviewed changes
relayer/chains/cosmos/grpc_query.go Outdated Show resolved Hide resolved
@agouin agouin enabled auto-merge (squash) March 10, 2023 20:02
@agouin agouin merged commit 1270279 into main Mar 10, 2023
@agouin agouin deleted the andrew/consolidate_cosmos_tx_broadcast branch March 10, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@boojamya boojamya Awaiting requested review from boojamya

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @jtieri