Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the provider IR instead of creating a new one #1346

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

vitsalis
Copy link
Contributor

When using the relayer with custom modules, I get the following errors

2023-11-23T16:50:05.318884Z     info    Could not get signers for msg when attempting to get the fee payer      {"error": "InterfaceRegistry requires a proper address codec implementation to do address conversion"}

This seems to happen due to the creation of the default InterfaceRegistry (which has failing address codecs) instead of the usage of the one under the provider codec.

@vitsalis
Copy link
Contributor Author

Thanks @Reecepbcups for running the build. Any thoughts on why this fails? On my local machine both make test and make interchaintest-events succeed.

@Reecepbcups
Copy link
Member

@vitsalis test here could just be flaky due to Github's CI runners. Will re-run

@vitsalis
Copy link
Contributor Author

vitsalis commented Dec 4, 2023

Any updates on this?

Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@jtieri jtieri merged commit c6e5bdb into cosmos:main Dec 4, 2023
18 checks passed
@vitsalis vitsalis deleted the vitsalis/use-provider-ir branch December 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants