Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, acks are not being cleared fully from the caches when giving up on sending a packet message after max retries.
I think this is caused by a race condition with flushing. Flushing performs queries and enqueues
chantypes.EventTypeSendPacket
or [chantypes.EventTypeRecvPacket
,chantypes.EventTypeWriteAck
] events when recvs or acks need to be relayed, respectively. These can be enqueued after the respective action was already successful and observed, which I believe is causing the looping ACKs.Some potential ways to handle this:
PacketSequenceCache
) of state for a sequence number where sequences expire after some amount of time. Then, when flushing, check if the sequence is already beyond the state that is about to be enqueued. If so, don't enqueue it.acknowledge_packet
event for the uneffected acks, which is currently necessary to clear the caches)Resolves #1359