Link custom client trusting period ratio #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarstonConnell
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
boojamya
reviewed
Dec 21, 2023
|
Done and done! |
boojamya
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #1357
Currently
rlyrequires clients on both chains to use the same trusting period ratio (85%) or specify a custom trusting period that then applies to both clients. Often you'll see chains like Axelar require connections that use a TP of 2/3 which can't be done using the custom TP flag if the chains have different unbonding times.This PR adds a new flag
client-tp-percentagewhich is set at a default of 85 but can be changed to anyint64value. This flag overwrites the 85% bonded ratio used byrly. However if a user specifies a custom TP with theclient-tpflag, this value is ignored just like before.