Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable limits for receiver and ICS-20 memo fields #1377

Merged
merged 11 commits into from
Jan 26, 2024

Commits on Jan 8, 2024

  1. Add ics20 memo limit

    agouin authored and jtieri committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8c5a62c View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Add max receiver size and ics-20 memo limit configuration

    This change introduces new configuration, MaxReceiverSize & ICS20MemoLimit, in the relayer, path processor, and the global config. It updates the existing functions and methods to utilize this new configuration property for managing and validating receiver and memo sizes in IBC related tasks.
    jtieri committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    983b168 View commit details
    Browse the repository at this point in the history
  2. Add WriteConfig function and update method names

    Added a new function WriteConfig in relayertest/system.go for testing. Also, updated method names in relayer.go to start with an uppercase letter for public visibility. Besides, upgraded Docker image version in localhost_client_test.go from v8.0.0-beta.1 to v8.0.0.
    jtieri committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3b414c2 View commit details
    Browse the repository at this point in the history
  3. test: add memo and receiver limit test

    Created the Memo and Receiver Limit test within the interchain test suite. This test evaluates the functionality of IBC transfers with a memo field length exceeding configured limit, as well as receiver field exceeding the limit. It also evaluates a successful IBC transfer for completeness.
    jtieri committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    fd952d1 View commit details
    Browse the repository at this point in the history
  4. test: update test for memo and receiver limit

    Adjusted the test case 'TestMemoAndReceiverLimit' to focus more on the functionality of sending transfers with a memo and receiver limit configured. This reduces the complexity of the test case, and it now focuses more closely on the actual purpose of the method. The general flow of the test has been maintained, but some unnecessary operations have been removed.
    jtieri committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    312d048 View commit details
    Browse the repository at this point in the history
  5. fix: properly unmarshal ics-20 packet data & remove debug print state…

    …ments
    
    This commit removes various debug print statements from the code, making it cleaner and easier to read. Additionally, it updates the way the 'transfertypes.ModuleCdc.Unmarshal' function is used to 'transfertypes.ModuleCdc.UnmarshalJSON', simplifying the overall structure of the code.
    jtieri committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    996e41c View commit details
    Browse the repository at this point in the history
  6. test: expand test users and IBC transfers in memo/receiver limit test

    The test for the memo receiver limit now supports four test users instead of two, allowing for more complex transfer scenarios. This change requires increased checks for account balances, as well as additional IBC transfers. This expansion helps ensure more comprehensive testing coverage and overall system validation.
    jtieri committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f7cc18e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6eb3d8f View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    d16093e View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    2fe56a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    d70aacd View commit details
    Browse the repository at this point in the history