-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default entrypoint for the container image #1473
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
I would think developers would expect the relayer binary to run (i.e. help menu) rather than to start. |
I am unsure how this will help when we are outside the container. |
Oh, seems like ibc-go image does the exact thing you said above. |
@onur-ozkan Yea i think just I am going to leave this for someone else to decide on the best approach |
Could you please clarify this a bit ? 🙂 At the moment there is no default entry point specified, so people have to specify one manually to make this container to do something useful. By doing so, the entry point we are adding with this PR will be overridden which means they won't notice any difference. |
Sorry, I was thinking docker CMD and not Entrypoint. Entrypoint is not a breaking change. Updated title and marketed out my comment. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just going to take action here and approve it as is. thanks! sorry for the wait here
Ci failure is due to rate limiting, will re-run this later |
I think most developers expect the application to start when running
docker run $image
instead of terminating the process without doing anything. This PR addresses that expectation.