Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch gas-prices from the chain config if provided #1508

Merged

Conversation

freak12techno
Copy link
Contributor

@freak12techno freak12techno commented Oct 12, 2024

Fixes #1507

The behaviour should be backwards-compatible:

  • if fees.fee_tokens is not empty, we use it
  • if it is empty, we fetch assets list and set the denom/gas price from it, if it's present (same way as before)
  • if asset list is also empty, we do not set it at all (same way as before)

@freak12techno freak12techno requested a review from a team as a code owner October 12, 2024 12:34
@freak12techno
Copy link
Contributor Author

@Reecepbcups can you take a look?

Copy link
Member

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reecepbcups Reecepbcups merged commit 6a22c2b into cosmos:main Oct 15, 2024
21 checks passed
@freak12techno freak12techno deleted the fix-chain-registry-gas-price-fetching branch October 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When fetching chain from chain-registry, gas-prices are calculated incorrectly
2 participants