Continued account prefix fixes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working for me! Looks like we have this issue fixed for the moment. |
|
This whole thing is just a race condition waiting to happen. We need to find a way that doesn't relay on global state. |
|
More specifically, inside at the function call boundary, if running inside a goroutine, the go scheduler can context switch. There may be a way to prevent this using something that prevents the go scheduler from context switching until the function returns. go routine safety doesn't generally matter in the SDK because it's largely single threaded. But it will probably end up mattering the in the relayer. |
|
@zmanian the global we are relying on is in the SDK. We would need to fix this issue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #43