-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chain: retry on db failure #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Mar 28, 2021
version: "3.9" | ||
services: | ||
ibc-0: | ||
image: "tendermint/gaia:v4.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: we rely on a gaia image directly, instead of a contributor-specific image
alexanderbez
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
March 29, 2021 15:05
colin-axner
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work! Relayer is looking better already!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary patch until a revision of the relayer's architecture takes place. Namely, this PR introduces a patch that performs a re-attempt of
MustGetLatestLightHeight
upon a database error. This prevents a running relayer from halting, which may further cause expired clients or "stuck" packets.I've also removed some cruft from the test/build area and introduced a more reliable two-chains testing setup. In future PRs, I'd like to remove all the one-off scripts and configs and rely on a more robust docker-driven testing system.
closes: #444
cc @colin-axner