Td/#1279/ica refactor #1370
Merged
Td/#1279/ica refactor #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmsdkeys
requested review from
coldice,
xavierlepretre,
gioelebonifetto and
8bitpal
as code owners
AndrewB9lab
reviewed
Apr 26, 2023
AndrewB9lab
approved these changes
Apr 27, 2023
xavierlepretre
approved these changes
Apr 27, 2023
charleenfei
reviewed
Apr 28, 2023
charleenfei
reviewed
Apr 28, 2023
charleenfei
reviewed
Apr 28, 2023
charleenfei
reviewed
Apr 28, 2023
Co-authored-by: Charly <charly@interchain.berlin>
tmsdkeys
commented
May 2, 2023
srdtrk
approved these changes
May 3, 2023
Co-authored-by: Xavier Leprêtre <xavierlepretre@users.noreply.github.com>
|
@coldice I think this one is good to merge. |
coldice
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation content update for IBC Concepts, Interchain Accounts v2 (!)
Closes: #1279
This PR updates the section on interchain accounts, post ibc-go v6 which contained a refactor of the ICA design
However, it is also aligned with a new direction for the 'Concepts' section of the developer portal which aims to be more high-level, with a lower maintenance burden. This results in less code snippets directly from the ibc-go implementation, but a high-level explanation of the concepts (IBC protocol) with references to the ibc-go docs, the 'Hands on exercise' and 'tutorials' sections of the portal
Notes for reviewers: Tried to focus on the protocol as much as possible, only moving into ibc-go implementation when talking about auth modules and ADR-008.
The changes in this Pull Request include (please tick all that apply):