Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmetic improvements to TmModal #1321

Closed
NodeGuy opened this issue Sep 17, 2018 · 0 comments
Closed

cosmetic improvements to TmModal #1321

NodeGuy opened this issue Sep 17, 2018 · 0 comments
Assignees
@jbibla
Labels
design-work-needed 🎨 issues that require design work before development good first issue 🙌

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Sep 17, 2018

Here's an example use of TmModal in PageValidator:

screen shot 2018-09-17 at 3 01 09 pm

In this application it would be nicer if:

  • the X button didn't exist (made optional)
  • there is a space between the icon and title
  • there is no horizontal line above the footer
  • the blue highlight around the OK button (when clicked) was the same dimensions as the button
@NodeGuy NodeGuy added design-work-needed 🎨 issues that require design work before development discuss labels Sep 17, 2018
@NodeGuy NodeGuy mentioned this issue Sep 17, 2018
Closed
17 tasks
@faboweb faboweb added low priority has been discussed, will be addressed later and removed discuss labels Sep 25, 2018
@faboweb faboweb mentioned this issue Sep 26, 2018
Closed
@fedekunze fedekunze removed the low priority has been discussed, will be addressed later label Nov 13, 2018
@jbibla jbibla mentioned this issue Nov 20, 2018
Merged
2 tasks
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
design-work-needed 🎨 issues that require design work before development good first issue 🙌
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NodeGuy @faboweb @jbibla @fedekunze