Implement new delegation design.

[NodeGuy]

To Do

David

• rewrite so that it doesn't use TmModal
• align left side of fields with Atom logo
• write unit tests
• E2E test
• warning dialog when user has zero atoms
  • Put space between warning icon and "Cannot Stake"
  • remove x button
  • remove horizontal line above footer
  • clicking on OK button without releasing shows outline larger than button
• move Amount to bottom of form

Fede

• write { bondDenom } within Amount field
• make To field read-only
  - [x] allow selection of previously-staked validators in From field MOVED to Implement redelegation #1293.
• abbreviate From address
• avoid redelegating to the same address
• close window when clicking outside of it
• autofocus Amount field
• make Stake button greyed-out when amount is invalid

@jbibla , please link your design files here.

[jbibla]

https://zpl.io/bWL0krn - Staking
https://zpl.io/VxlvdWk - Restaking

[NodeGuy]

Please remove issues from the backlog when moving them into Scrumptious.

[NodeGuy]

Hold on cowboys, this is dependent on #1171 which is also part of this sprint.

[jbibla]

it doesn't need to be dependent on #1171 - we can add a button to the existing profile page and work on the new modal ...

[faboweb]

I agree with Jordan. I would see this as a replacement for PageBond. We can add the 2 buttons to the old PageValidator for now and replace the checkboxes (and shoppingCart logic) already.

[jbibla]

yes, let's please get rid of shoppingCart.

🛒 🛒 🛒

[NodeGuy]

OK

[NodeGuy]

After looking at the designs it seems this isn't about redelegation—it's about delegation and undelegation, right? I'm going to rename the title.

[faboweb]

https://zpl.io/VxlvdWk - Restaking

This treats redelegation.

[jbibla]

we have to account for

delegation / staking / bonding
undelegation / unstaking / unbonding
redelegation / restaking / rebonding

[faboweb]

Follow up for redelegation: #1293

[NodeGuy]

Our standard modals have a darker background for the header:

There's no such distinction in the design. Do you care or should I reimplement TmModal for this one?

[NodeGuy]

Split out undelegation to #1294 and removing PageBond to #1295.

[faboweb]

the design for staking is actually not the same modal we have already. It is more a pop-over on the bottom like when you write a new email in google inbox. maybe it should still have the same layout. @jbibla can you help out?

[NodeGuy]

Oh, OK. I see another difference: With TmModal the rest of the window is darkened but that's not happening here. I won't use it.

[fedekunze]

close window when clicking outside of it

@NodeGuy do we need this point if we are already adding the "Close" and X buttons ?

[fedekunze]

allow selection of previously-staked validators in From field

So that would basically turn the delegation into a redelegation, right ? I'm asking because eventually we'll end up splitting that POST endpoint to submit delegations (see cosmos/cosmos-sdk#2191). So will have add this logic here as well

[NodeGuy]

@NodeGuy do we need this point if we are already adding the "Close" and X buttons ?

@faboweb requested it and I think it's a good idea.

So that would basically turn the delegation into a redelegation, right ? I'm asking because eventually we'll end up splitting that POST endpoint to submit delegations (see cosmos/cosmos-sdk#2191). So will have add this logic here as well

I guess so but haven't seen a spec for any of this. @faboweb is there a spec?

[faboweb]

So that would basically turn the delegation into a redelegation, right ?

Yep. Maybe do delegation first and then do redelegation in another PR.

I'm asking because eventually we'll end up splitting that POST endpoint to submit delegations

Let's not handle problems we do not yet have. When the split happens, the logic on our hand probably can be easily changed.

[NodeGuy]

Created new issue about warning dialog: #1321