composition test & close buttons for new delegation implementation #1323
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1323 +/- ##
========================================
Coverage 89.26% 89.26%
========================================
Files 84 84
Lines 1733 1733
Branches 96 96
========================================
Hits 1547 1547
Misses 179 179
Partials 7 7
|
NodeGuy
force-pushed
the
david/1219-composition-tests
branch
from
7fb1fc8 to
1d775f8
Compare
NodeGuy
force-pushed
the
david/1219-composition-tests
branch
from
1d775f8 to
e3e1271
Compare
NodeGuy
changed the title
|
|
||
| await submitDelegation({ amount: 10 }) | ||
|
|
||
| expect($store.dispatch.mock.calls).toEqual([ |
There was a problem hiding this comment.
I think snapshots are a bad idea because:
- They're stored in a separate file so you can't see what the test is expecting easily.
- They require an external tool to manipulate (instead of just your code editor).
simpler = better
There was a problem hiding this comment.
They're stored in a separate file so you can't see what the test is expecting easily
true.
They require an external tool to manipulate (instead of just your code editor)
false.
I agree with simpler = better. But it is a lot more comfortable to update snapshots then go through code on a format change and change all the expected values. Let's discuss it.
There was a problem hiding this comment.
I agree that snapshots are useful for tracking a format change (e.g., in HTML) as part of Golden Master testing.
The above code is a unit test (not generating HTML), which is a different kind of test. What would be the benefit of using snapshots here?
There was a problem hiding this comment.
I have the feeling that having huge json responses in code are too much noise that distract.
|
screenshots would be helpful @NodeGuy 📸 |
|
I added a screenshot. |
Make progress against #1219
Description:
Adds a composition test and close buttons to the new Stake modal.