David/1219 new delegation #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 24, 2018 13:59
Remove old E2E tests for PageBond rather than fixing them.
Codecov Report
@@ Coverage Diff @@
## develop #1355 +/- ##
========================================
Coverage 89.27% 89.27%
========================================
Files 84 84
Lines 1735 1735
Branches 96 96
========================================
Hits 1549 1549
Misses 179 179
Partials 7 7
|
faboweb
reviewed
Sep 25, 2018
faboweb
reviewed
Sep 25, 2018
| @@ -16,6 +17,10 @@ const Wrapper = () => { | |||
| }) | |||
| } | |||
|
|
|||
| test(`renders correctly`, () => { | |||
| expect(htmlBeautify(Wrapper().html())).toMatchSnapshot() | |||
There was a problem hiding this comment.
note: wrapper.vm.$el also prints a formated dom representation
There was a problem hiding this comment.
Thank you, how is that helpful? Is it already beautified?
faboweb
reviewed
Sep 25, 2018
| // "Delegate steak in validator updated correctly" | ||
| // ) | ||
|
|
||
| .click(`//button/*[. = 'Stake']`) |
There was a problem hiding this comment.
I have the feeling an id would be better here. What do you think?
There was a problem hiding this comment.
Sure, that's fine. After I see your response to the comment above I can create another PR with it.
There was a problem hiding this comment.
Not a blocking concern for me.
There was a problem hiding this comment.
OK then I won't bother.
faboweb
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1219
Description:
Adds snapshot and E2E tests to complete the feature.