Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Tendermint UI library #1432

Closed
1 task
faboweb opened this issue Oct 8, 2018 · 7 comments · Fixed by #1759
Closed
1 task

Integrate Tendermint UI library #1432

faboweb opened this issue Oct 8, 2018 · 7 comments · Fixed by #1759
Assignees
@faboweb
Labels
epic

Comments

@faboweb
Copy link
Collaborator

faboweb commented Oct 8, 2018 •
edited
Loading

We decided to fuse https://github.com/tendermint/ui into this repository.

Scope:
@faboweb faboweb changed the title Integrate tendermint UI library Integrate Tendermint UI library Oct 8, 2018
@fedekunze
Copy link
Contributor

I think we should add some folders to the common as well in order to categorize better the TmUI components. common is currently very packed with components

@jbibla
Copy link
Collaborator

jbibla commented Oct 9, 2018

good thinking @fedekunze - i would propose including a folder for session and for modals. are there others you can think of?

This was referenced Oct 9, 2018
Closed
Closed
@fedekunze
Copy link
Contributor

also, do we need to still use the Tm prefix? @jbibla what do you think ?

@fedekunze
Copy link
Contributor

https://www.notion.so/cosmosvoyager/Repository-Architecture-408ed911bc524d37b05ab562be78baf7

@faboweb
Copy link
Collaborator Author

faboweb commented Dec 13, 2018

do we need to still use the Tm prefix

not really

@faboweb
Copy link
Collaborator Author

faboweb commented Dec 13, 2018

How about making "session" an own folder: "components/session"?

@jbibla
Copy link
Collaborator

jbibla commented Dec 13, 2018

How about making "session" an own folder: "components/session"?

that makes sense to me!

prefixes

please, no more prefixes 😆

@faboweb faboweb mentioned this issue Dec 19, 2018
Merged
3 tasks
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fabo/1432 reintegrate tendermint/UI luniehq/lunie
3 participants
@faboweb @jbibla @fedekunze