Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageStaking and TabValidators have a lot of duplicate code #1445

Closed
jbibla opened this issue Oct 10, 2018 · 1 comment · Fixed by #1483
Closed

PageStaking and TabValidators have a lot of duplicate code #1445

jbibla opened this issue Oct 10, 2018 · 1 comment · Fixed by #1483
Assignees
@jbibla
Labels
blocked ✋ issues blocked by other implementations/issues refactor

Comments

@jbibla
Copy link
Collaborator

jbibla commented Oct 10, 2018 •
edited
Loading

some examples:

somethingToSearch()
vpTotal()
enrichedDelegates()
sortedFilteredEnrichedDelegates()
@NodeGuy NodeGuy self-assigned this Oct 19, 2018
@NodeGuy NodeGuy mentioned this issue Oct 19, 2018
Merged
2 tasks
@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Oct 23, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 24, 2018

Blocked by #1480.

@jbibla jbibla self-assigned this Oct 26, 2018
This was referenced Nov 13, 2018
Merged
Merged
Merged
Merged
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
blocked ✋ issues blocked by other implementations/issues refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

David/1446 delegations filters luniehq/lunie
2 participants
@NodeGuy @jbibla