David/1446 delegations filters #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 19, 2018 19:33
…46-delegations-filters # Conflicts: # app/src/renderer/components/staking/PageStaking.vue # app/src/renderer/components/staking/TabValidators.vue # test/unit/specs/components/staking/PageStaking.spec.js # test/unit/specs/components/staking/TabMyDelegations.spec.js # test/unit/specs/components/staking/TabValidators.spec.js # test/unit/specs/components/staking/__snapshots__/TabValidators.spec.js.snap
NodeGuy
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1483 +/- ##
===========================================
+ Coverage 96.93% 96.96% +0.03%
===========================================
Files 91 92 +1
Lines 1727 1712 -15
Branches 77 77
===========================================
- Hits 1674 1660 -14
Misses 43 43
+ Partials 10 9 -1
|
added 5 commits
October 19, 2018 20:08
NodeGuy
changed the title
|
Blocked by #1480. |
jbibla
previously approved these changes
Oct 26, 2018
jbibla
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1446 and closes #1445
Description:
Refactors validator tables by creating new component
TableValidators. Has the effect of fixing column sorting in TabMyDelegations. Also removes redundant code from PageStaking.❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer