Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate more meaningful stack traces with source mapping #1451

Closed
NodeGuy opened this issue Oct 10, 2018 · 1 comment · Fixed by #1506
Closed

Generate more meaningful stack traces with source mapping #1451

NodeGuy opened this issue Oct 10, 2018 · 1 comment · Fixed by #1506
Assignees
@faboweb
Labels
refactor

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 10, 2018 •
edited
Loading

We concatenate our source code with Webpack, making line numbers in stack traces less meaningful, e.g.,

TypeError: Cannot read property 'words' of null
  at Object._doReset (/private/var/folders/9y/jgtj1b7n6mz2_rtg61cvdb140000gn/T/AppTranslocation/610C7176-3827-4A84-AAD2-D00C52F8CC9F/d/Cosmos%20Voyager.app/Contents/Resources/app/dist/renderer.js:107634:33)
  at Object.reset (/private/var/folders/9y/jgtj1b7n6mz2_rtg61cvdb140000gn/T/AppTranslocation/610C7176-3827-4A84-AAD2-D00C52F8CC9F/d/Cosmos%20Voyager.app/Contents/Resources/app/dist/renderer.js:7434:19)
  at Object.reset (/private/var/folders/9y/jgtj1b7n6mz2_rtg61cvdb140000gn/T/AppTranslocation/610C7176-3827-4A84-AAD2-D00C52F8CC9F/d/Cosmos%20Voyager.app/Contents/Resources/app/dist/renderer.js:7772:27)
  at Object.init (/private/var/folders/9y/jgtj1b7n6mz2_rtg61cvdb140000gn/T/AppTranslocation/610C7176-3827-4A84-AAD2-D00C52F8CC9F/d/Cosmos%20Voyager.app/Contents/Resources/app/dist/renderer.js:7419:19)
  at Object.subtype.init (/private/var/folders/9y/jgtj1b7n6mz2_rtg61cvdb140000gn/T/AppTranslocation/610C7176-3827-4A84-AAD2-D00C52F8CC9F/d/Cosmos%20Voyager.app/Contents/Resources/app/dist/renderer.js:6194:46)
...
(9 additional frame(s) were not displayed)

Use source mapping so that we can see the line numbers in the original source code.
@NodeGuy NodeGuy mentioned this issue Oct 10, 2018
Closed
@faboweb faboweb self-assigned this Oct 30, 2018
@faboweb
Copy link
Collaborator

faboweb commented Oct 31, 2018

Scope:

  • enable sourcemaps in webpack
  • check that errors in chrome use sourcemaps
  • bonus: check that errors in sentry use sourcemaps

@faboweb faboweb mentioned this issue Oct 31, 2018
Merged
2 tasks
This was referenced Nov 13, 2018
Merged
Merged
Merged
Merged
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fabo/1451 provide better sourcemaps luniehq/lunie
2 participants
@NodeGuy @faboweb