Fabo/1451 provide better sourcemaps #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1506 +/- ##
========================================
Coverage 96.96% 96.96%
========================================
Files 92 92
Lines 1712 1712
Branches 77 77
========================================
Hits 1660 1660
Misses 43 43
Partials 9 9
|
|
That looks like an improvement but the line numbers are still not mapping back to the source files. |
|
Can you give an example? I just tested it again and the line number for |
|
Oh I see, I was mistaking all of those files in the stack traces as ours but as you mentioned yesterday they are boilerplate from Webpack, etc. Great job! |
NodeGuy
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1451
Description:
BEFORE:
AFTER:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer