Merge pull request #1506 from cosmos/fabo/1451-provide-better-sourcemaps

Fabo/1451 provide better sourcemaps
luniehq · Nov 1, 2018 · e808fab · e808fab
2 parents a65526b + e98684b
commit e808fab
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 * [\#1487](https://github.com/cosmos/voyager/issues/1487) Fixed running of local testnet. @NodeGuy
 * [\#1480](https://github.com/cosmos/voyager/issues/1480) Fixed "duplicate CONN" errors in E2E tests. @NodeGuy
 * [\#1480](https://github.com/cosmos/voyager/issues/1480) Fixed false detection of node crash in e2e test start. @faboweb
+* [\#1451](https://github.com/cosmos/voyager/issues/1451) Provide better sourcemaps to make debugging easier. @faboweb
 
 ## [0.10.7] - 2018-10-10
 

diff --git a/app/src/main/index.js b/app/src/main/index.js
@@ -141,6 +141,8 @@ function createWindow() {
       mainWindow.show()
       if (DEV || JSON.parse(process.env.COSMOS_DEVTOOLS || `false`)) {
         mainWindow.webContents.openDevTools()
+        // we need to reload at this point to make sure sourcemaps are loaded correctly
+        mainWindow.reload()
       }
       if (DEV) {
         mainWindow.maximize()

diff --git a/webpack.main.config.js b/webpack.main.config.js
@@ -6,6 +6,10 @@ const path = require(`path`)
 const webpack = require(`webpack`)
 
 let mainConfig = {
+  devtool:
+    process.env.NODE_ENV === `production`
+      ? `#source-map`
+      : `#inline-source-map`,
   entry: {
     main: path.join(__dirname, `app/src/main/index.js`)
   },

diff --git a/webpack.renderer.config.js b/webpack.renderer.config.js
@@ -15,7 +15,10 @@ function resolve(dir) {
 }
 
 let rendererConfig = {
-  devtool: `#eval-source-map`,
+  devtool:
+    process.env.NODE_ENV === `production`
+      ? `#source-map`
+      : `#inline-source-map`,
   entry: {
     renderer: path.join(__dirname, `app/src/renderer/main.js`)
   },