Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1451 provide better sourcemaps #1506

Merged
merged 6 commits into from
Nov 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
* [\#1487](https://github.com/cosmos/voyager/issues/1487) Fixed running of local testnet. @NodeGuy
* [\#1480](https://github.com/cosmos/voyager/issues/1480) Fixed "duplicate CONN" errors in E2E tests. @NodeGuy
* [\#1480](https://github.com/cosmos/voyager/issues/1480) Fixed false detection of node crash in e2e test start. @faboweb
* [\#1451](https://github.com/cosmos/voyager/issues/1451) Provide better sourcemaps to make debugging easier. @faboweb

## [0.10.7] - 2018-10-10

Expand Down
2 changes: 2 additions & 0 deletions app/src/main/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ function createWindow() {
mainWindow.show()
if (DEV || JSON.parse(process.env.COSMOS_DEVTOOLS || `false`)) {
mainWindow.webContents.openDevTools()
// we need to reload at this point to make sure sourcemaps are loaded correctly
mainWindow.reload()
}
if (DEV) {
mainWindow.maximize()
Expand Down
4 changes: 4 additions & 0 deletions webpack.main.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ const path = require(`path`)
const webpack = require(`webpack`)

let mainConfig = {
devtool:
process.env.NODE_ENV === `production`
? `#source-map`
: `#inline-source-map`,
entry: {
main: path.join(__dirname, `app/src/main/index.js`)
},
Expand Down
5 changes: 4 additions & 1 deletion webpack.renderer.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ function resolve(dir) {
}

let rendererConfig = {
devtool: `#eval-source-map`,
devtool:
process.env.NODE_ENV === `production`
? `#source-map`
: `#inline-source-map`,
entry: {
renderer: path.join(__dirname, `app/src/renderer/main.js`)
},
Expand Down