-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent way of writing unit tests #1543
Comments
I used |
I like |
I like how the jasmine syntax reads more like a real description (spec): it should return an object property x when I give it input y |
@jbibla how comes you think this is such a complex task? |
i suppose if we're only changing |
Description:
There are currently two ways we're doing unit testing:
describe()
andit()
(eg: PageStaking.spec.js)test()
(eg: DelegationModal.spec.js)We should stick with one or another, so we'd have to choose either
1.
or2.
, update our coding guidelines with the decision and do a refactor of our unit tests.The text was updated successfully, but these errors were encountered: