Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django-transparent demo app #46

Merged
merged 5 commits into from
May 27, 2022

Conversation

iamnotacake
Copy link
Contributor

@iamnotacake iamnotacake commented Apr 1, 2022

  • Remove patches that make Python transform bytes (returned by AcraServer after decryption) to text string.
  • Update AcraServer encryptor config to enable transparent types.
  • Bump acra-keymaker and acra-server versions to 0.93.
  • Make run.sh support Manjaro Linux as well.

UPD:

  • Added ability to transparently encrypt Dashboard Categories with integer position field.
  • Added corresponded migrations

DO NOT merge until Acra 0.93 is released.

Also, some checks are still in progress...

* Remove patches that make Python transform bytes (returned by
  AcraServer after decryption) to text string.
* Update AcraServer encryptor config to enable transparent types.
* Bump acra-keymaker and acra-server versions to 0.93.
* Make `run.sh` support Manjaro Linux as well.
@iamnotacake iamnotacake requested a review from Lagovas April 1, 2022 10:57
@iamnotacake iamnotacake marked this pull request as ready for review April 1, 2022 15:19
Copy link
Contributor

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but can I ask you save here your screenshot with incorrect TLS keys when AcraServer returned error default values? just for history and understanding how it should be and what expect when verify one more time after merging (after release)?

@iamnotacake
Copy link
Contributor Author

Here's how the demo blog post looks like with failed decryption, "error" is the placeholder in encryptor config.
Screenshot from 2022-04-01 15-19-58

Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have any questions / comments

Artem Zhmaka and others added 3 commits April 21, 2022 18:18
Added dashboard category transpent encryption with int Type Awerness
@Zhaars Zhaars requested review from vixentael and Lagovas April 21, 2022 16:33
- name
- position
encrypted:
- column: "position"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... encryption position values works on UI? is it ordered on UI via position values, not by order by statement on db side? did you check it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the UI and didnt found position usage anywhere.

@@ -6,7 +6,7 @@ services:
# - ./.acrakeys/acra-server/${ACRA_CLIENT_ID}_storage.pub
# - ./.acrakeys/acra-server/${ACRA_CLIENT_ID}_storage_sym
acra-keymaker_client:
image: "cossacklabs/acra-keymaker:${ACRA_DOCKER_IMAGE_TAG:-0.93.0}"
image: "cossacklabs/acra-keymaker:${ACRA_DOCKER_IMAGE_TAG:-0.92.0}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we should leave 0.93.0 )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it actual change? I had it, but fixed and dont see it in changed files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, looks like a bug in github. because on files tab everything is okay
image

@Lagovas Lagovas merged commit ef7080c into master May 27, 2022
@Lagovas Lagovas deleted the anatolii/T2516-update-django-transparent-demo branch May 27, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants