-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update django-transparent demo app #46
Update django-transparent demo app #46
Conversation
* Remove patches that make Python transform bytes (returned by AcraServer after decryption) to text string. * Update AcraServer encryptor config to enable transparent types. * Bump acra-keymaker and acra-server versions to 0.93. * Make `run.sh` support Manjaro Linux as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. but can I ask you save here your screenshot with incorrect TLS keys when AcraServer returned error
default values? just for history and understanding how it should be and what expect when verify one more time after merging (after release)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have any questions / comments
Added dashboard category transpent encryption with int Type Awerness
redo redundant changes
Fixed README.md file
- name | ||
- position | ||
encrypted: | ||
- column: "position" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... encryption position values works on UI? is it ordered on UI via position values, not by order by
statement on db side? did you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the UI and didnt found position
usage anywhere.
@@ -6,7 +6,7 @@ services: | |||
# - ./.acrakeys/acra-server/${ACRA_CLIENT_ID}_storage.pub | |||
# - ./.acrakeys/acra-server/${ACRA_CLIENT_ID}_storage_sym | |||
acra-keymaker_client: | |||
image: "cossacklabs/acra-keymaker:${ACRA_DOCKER_IMAGE_TAG:-0.93.0}" | |||
image: "cossacklabs/acra-keymaker:${ACRA_DOCKER_IMAGE_TAG:-0.92.0}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we should leave 0.93.0 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actual change? I had it, but fixed and dont see it in changed files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run.sh
support Manjaro Linux as well.UPD:
Dashboard Categories
with integer position field.DO NOT merge until Acra 0.93 is released.
Also, some checks are still in progress...