Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly handle null values in columns #286

Merged
merged 1 commit into from
Nov 22, 2018
Merged

correctly handle null values in columns #286

merged 1 commit into from
Nov 22, 2018

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Nov 22, 2018

  • fixed counting result length of packet
  • added usage of null columns in tests to meet such errors in the future

shadinua
shadinua approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@shadinua shadinua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

vixentael
vixentael approved these changes Nov 22, 2018
View reviewed changes
Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Lagovas Lagovas merged commit fd576c0 into cossacklabs:master Nov 22, 2018
@Lagovas Lagovas deleted the lagovas/T867-fix-data-length-count branch December 17, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadinua shadinua shadinua approved these changes

@vixentael vixentael vixentael approved these changes

Assignees
No one assigned
Labels
core postgresql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lagovas @vixentael @shadinua