public methods to extract table aliases from query #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix govet, use pointer to struct with sync.Once return decrypted string as with without encoding if it simple string
vixentael
approved these changes
Jan 15, 2019
vixentael
reviewed
Jan 15, 2019
| @@ -89,8 +89,8 @@ func DecodeOctal(data []byte) ([]byte, error) { | |||
|
|
|||
| // DecodeEscaped with hex or octal encodings | |||
| func DecodeEscaped(data []byte) ([]byte, error) { | |||
| hexdata := data[2:] | |||
| if bytes.Equal(data[:2], []byte{'\\', 'x'}) { | |||
| if len(data) > 2 && bytes.Equal(data[:2], []byte{'\\', 'x'}) { | |||
There was a problem hiding this comment.
there check of escape type. hex encoding or not. second case printable chars used as is and string may contain <2 characters that are printable and will be correct
There was a problem hiding this comment.
hex encoded must have prefix \x before encoded string so here we check it
storojs72
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTablesWithAliasesfunction (was method) andAliasedTableNameto reuse it in enterprise code