Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribute AcraWriter Android via maven #310

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

vixentael
Copy link
Collaborator

  • add necessary Android distribution tools, like gradle
  • add build.gradle and Android manifest
  • push acrawriter that depends on themis-android to bintray
  • update example to use acrawriter from bintray
  • add badge to Readme (updated docs will come with new release)

Usage:

build.gradle

repositories {
        // whatever you have here, add maven
        maven { url "https://dl.bintray.com/cossacklabs/maven/" }
}

app/build.gradle

dependencies {
     // ....
    implementation 'com.cossacklabs.com:acrawriter:1.0.1'
}

bintray
https://bintray.com/cossacklabs/maven/acrawriter#

Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

void generateAcraStructLocally() throws SecureCellException, NullArgumentException, InvalidArgumentException {
String message = "local acrastruct";

String acraTranslatorPublicKey = "VUVDMgAAAC240mpnAx8FSrZxhVNPsnhhZFYAm0+ARiRDdXPKAW0vI/2AY0QM";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use hardcoded public key here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's example that illustrates a typical flow of mobile app: it gets public key from somewhere (via network request) in base64 encoding. to make this example work without inet connection, the key is hardcoded.

I believe for mobile devs it's more useful to see encoding-decoding and to understand that they can get this key from somewhere, than to use local keygen.

gradlew Show resolved Hide resolved
@vixentael vixentael merged commit 03ba182 into master Feb 5, 2019
@vixentael vixentael deleted the vixentael/acrawriter-android branch February 5, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants