Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix querycapture duplicate logs #318

Merged
merged 4 commits into from
Feb 19, 2019
Merged

fix querycapture duplicate logs #318

merged 4 commits into from
Feb 19, 2019

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Feb 19, 2019

found that when censor starts and read existing queries from disk he doesn't update queryindex and work with queryindex == 0. and then after serialization timer's tick it dump buffered queries that was appended (all queries stored in handler.Queries array after queryindex position that store index of last dumped query). And it dump all queries loaded at start and only after that update queryindex to correct value Length(loadedQueries).

Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!
must be totally my fault.

@Lagovas Lagovas merged commit 41001c5 into cossacklabs:master Feb 19, 2019
@Lagovas Lagovas deleted the lagovas/fix-querycapture-duplicate-logs branch February 20, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants