remove side effect from re-using generated zones in other test modules #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small refactoring that allow to re-use generated zones from ACE integration tests in AEE tests.
If AEE tests will import some TestCase from ACE and
zonesglobal variable with pre-generated values, thenunittestmodule will callsetUpModule+tearDownModulefor ACE tests initialization and oncesetUpModulefor AEE tests that call basesetUpModule.zoneswill contain all zones that was generated insetUpModulefor ACE but files that store keys will be deleted intearDownModule. Butzonesvariable wasn't updated after deletion and AEE will try to use not-existing keys from first generation