Remove authmanager and webconfig #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-authmanager-webconfig
vixentael
requested changes
Nov 17, 2021
vixentael
reviewed
Nov 17, 2021
Co-authored-by: vixentael <vixentael@users.noreply.github.com>
will ignore it without any log messages (I have checked it ). acra doesn't validate config for appearing keys that are not used. |
vixentael
approved these changes
Nov 17, 2021
…om:cossacklabs/acra into lagovas/T2142-remove-authmanager-webconfig
Our tests check that something handled correctly according to log output.Aand some of them fork process with log redirection to file. Before reading the file called f.Flush to be sure that all buffered data dumped to FS. But some logs may be buffered in the process itself that have written to stdout. And tests don't find expected log entries in the output. So now we turn off bufferization to be sure that we have all available logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to remove webconfig and authmanager. So here:
acra-keymakerandacra-keysgeneration symmetric key for basic auth credentialsDraft until I run and check all dockerfiles and be sure that all of them work. All other staff is ready to review.
Updated documentation: cossacklabs/product-docs#199
Updated engineering demo: cossacklabs/acra-engineering-demo#32
Checklist
with new changes