Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated python examples #463

Merged
merged 16 commits into from
Nov 25, 2021
Merged

Updated python examples #463

merged 16 commits into from
Nov 25, 2021

Conversation

ZhmakAS
Copy link
Contributor

@ZhmakAS ZhmakAS commented Nov 25, 2021

Updated python examples with ability to use TLS authentication. Also, updated python sqlalchemy python wrapper with usage of LargeBinary base type in AcraBinary type.

This PR is a part of T2240

Checklist

fixed acra-keys with redis communication
added redis build flags for unit tests
fixed integration tests to work with Readis
delete redundant logging
delete redundat logging
fixed general_validation tests
rm redundant changes
added TEST_REDIS env to configure run of integration tests
Updated python examples
@ZhmakAS ZhmakAS requested a review from Lagovas November 25, 2021 12:55
fixed example with zone
@@ -106,6 +106,18 @@ def write_data(data, connection):
default=get_default('print', False),
help='Print data (use --zone_id to set specific ZoneId '
'which will be used to fetch data)')
parser.add_argument('--ssl_mode', action='store_true',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lte's use modern protocol names instead of legacy names. It's okay to leave --ssl_mode because it's common name for mysql/postgresql parameter, but I suggest to use tls_root_cert/tls_key/tls_cert instead of ssl_*.

fixed after review: updated CLI params to tls_* based
@ZhmakAS ZhmakAS requested a review from Lagovas November 25, 2021 14:29
@ZhmakAS ZhmakAS merged commit fdcec68 into master Nov 25, 2021
@Lagovas Lagovas deleted the zhars/T2240/updated_python_examples branch February 4, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants