-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated python examples #463
Merged
Merged
+101
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed acra-keys with redis communication
added redis build flags for unit tests
fixed integration tests to work with Readis
delete redundant logging
delete redundat logging
fixed general_validation tests
fixed after review
fixed after review
fixed after review
rm redundant changes
added TEST_REDIS env to configure run of integration tests
# Conflicts: # CHANGELOG_DEV.md
Updated python examples
fixed example with zone
Lagovas
reviewed
Nov 25, 2021
@@ -106,6 +106,18 @@ def write_data(data, connection): | |||
default=get_default('print', False), | |||
help='Print data (use --zone_id to set specific ZoneId ' | |||
'which will be used to fetch data)') | |||
parser.add_argument('--ssl_mode', action='store_true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lte's use modern protocol names instead of legacy names. It's okay to leave --ssl_mode
because it's common name for mysql/postgresql parameter, but I suggest to use tls_root_cert/tls_key/tls_cert
instead of ssl_*
.
fixed after review: updated CLI params to tls_* based
Lagovas
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated python examples with ability to use TLS authentication. Also, updated python sqlalchemy python wrapper with usage of LargeBinary base type in AcraBinary type.
This PR is a part of
T2240
Checklist
with new changes