Fix acra-keys list with keystore v1
#530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v1 keystore can have two paths for public and private keys. But most often they are the same. The `ListKeys` function of keystore doesn't check if these paths are the same, and if yes, enumerates all keys twice. Change this by checking the paths.
The filename is `secure_log_key` and it's parsed as a regular client key, which consists of `<client_id>_<purpose>_<kind>`. So in case of `secure_log_key` the client_id is `secure, which is not correct. Fix this by setting empty array as a ClientId.
[skip ci]
Lagovas
reviewed
Apr 19, 2022
| } | ||
| } | ||
|
|
||
| // copied from `acra-keys list` code |
There was a problem hiding this comment.
it's the good reason to move this function to keystore/utils.go (probably) and use it in tests and acra-tools too, if we already need it in several places) Maybe in the future we will need it in one more place
Removes code duplication.
G1gg1L3s
added a commit
to cossacklabs/product-docs
that referenced
this pull request
Apr 19, 2022
The result of cossacklabs/acra#530.
vixentael
pushed a commit
to cossacklabs/product-docs
that referenced
this pull request
Apr 20, 2022
* Replace v2 with v1 in some examples * Fix acra-keys list table The result of cossacklabs/acra#530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with
acra-keysthat were discovered at cossacklabs/product-docs#245 (comment).The changes:
keystore.ListKeysnow lists files only once, if public key path is the same as private key one.secureis no longer interpreted as client idChecklist
with new changes
CHANGELOG.md is updated (in case of notable or breaking changes)Benchmark results are attached (if applicable)Example projects and code samples are up-to-date (in case of API changes)