Extend Acra with latest changes #547
Conversation
Extend sqlparser to support set key TO value gramar
Added sqlparser unit tests
Fixed after review
Remove redundant things
Last changes improvements
…atest_changes # Conflicts: # sqlparser/sql.go
| } | ||
|
|
||
| if _, ok := subSelect.SelectExprs[0].(*sqlparser.StarExpr); ok { | ||
| return nil, errUnsupportedExpression |
There was a problem hiding this comment.
maybe we should leave TODO that we plan to support it with passed encryptor_config at the future?
There was a problem hiding this comment.
Hmm, but all this block is related to handling such kinds of queries.
SELECT a, (SELECT b FROM table2) FROM table1;
So here we have some checks that select expression should be only one in any case and we don't need to use encryptor_config here. Am I wrong?
There was a problem hiding this comment.
oh, I missed that there is subSelect, not starSelect that requires encryptor_config
| @@ -48,19 +48,23 @@ func parseJoinTablesInfo(joinExp *sqlparser.JoinTableExpr, tables *[]string, ali | |||
| if ok { | |||
| // here we reach the last leaf in the JoinTableExpr recursive tree, processing SHOULD be stopped in this block. | |||
| // and we should process remaining RightExpr and LeftExpr leafs more before exit. | |||
| name, alias, ok := getRightJoinTableInfo(joinExp) | |||
There was a problem hiding this comment.
can you update comment for this function with updated internal logic? what and how it actually parse information about tables
| if !ok { | ||
| t.Fatal("Test query should be Select expression") | ||
| } | ||
| `select t1.number AS t1_number, t2.number AS t2_number from (select * from tablex) AS t JOIN (table1 AS t1 JOIN table2 AS t2 ON t1.id = t2.exam_type_id) ON t.version_id = |
There was a problem hiding this comment.
can you add comments what actually we check here and what difference between cases?
additionally lets verify reverse ordered columns in SELECT statement? If we join t1 with t2 and t3 then lets check SELECT t3.*, t1.*, t2.* and check that they should not be ordered in same way
Added more comments
| func getRightJoinTableInfo(joinExp *sqlparser.JoinTableExpr) (string, string, bool) { | ||
| // in case of more complex JOINs constructions like `JOIN (table1 AS t1 JOIN table2 AS t2 ON ... JOIN table3 ...) ON ...` | ||
| // represented by sqlparser.ParenTableExpr it runs parseJoinTablesInfo itself recursively to collect tableName and its alias info inside this block | ||
| func getRightJoinTableInfo(joinExp *sqlparser.JoinTableExpr, tables *[]string, aliases map[string]string) bool { |
There was a problem hiding this comment.
can you explain here why we rely only on RightExpr and doesn't touch LeftExpr?
Updated Acra with a couple of latest fixes.
NULLS FIRST/LASTstatements;mapColumnsToAliasesfunction to support some JOINS queries and queries wish subqueries;Added tests to cover corresponding functionality;
Checklist
with new changes