Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR were removed limitation that RETURNING statements should contain only *ColName structs and allow other types, like sql literals which ignored by acra-server. According to postgresql's and mysql's docs,
returning
may contain same expressions that is supported by SELECT. So, were updated sql's grammar to be compatible with SelectExprs.Due to mariadb supports returning since 10.5.0, additionally was updated image for mariadb-ssl to the fresh one 10.7.1 and removed skip condition in integration tests that didn't run tests at all for mariadb with
returning
cases. Because base class BaseTestCase skipped non-tls tests.After fixing running integration tests for mariadb and updating image, I found that our index.txt contains serial from old certs, and current certs tests/ssl/mysql/mysql.crt has another one. Which were generated for engineering-demo, copied there and left here as is without updating index.txt. But our current mariadb-ssl uses old certs with serial saved in index.txt. So I copied correct certs from current cossacklabs/mariadb-ssl:10.3-1 image and placed here. Otherwise acra will deny certs in OCSP checks due to mismatch serial in index.txt and current mysql.crt
Checklist
with new changes