Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend returning statement #584

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Sep 27, 2022

In this PR were removed limitation that RETURNING statements should contain only *ColName structs and allow other types, like sql literals which ignored by acra-server. According to postgresql's and mysql's docs, returning may contain same expressions that is supported by SELECT. So, were updated sql's grammar to be compatible with SelectExprs.

Due to mariadb supports returning since 10.5.0, additionally was updated image for mariadb-ssl to the fresh one 10.7.1 and removed skip condition in integration tests that didn't run tests at all for mariadb with returning cases. Because base class BaseTestCase skipped non-tls tests.

After fixing running integration tests for mariadb and updating image, I found that our index.txt contains serial from old certs, and current certs tests/ssl/mysql/mysql.crt has another one. Which were generated for engineering-demo, copied there and left here as is without updating index.txt. But our current mariadb-ssl uses old certs with serial saved in index.txt. So I copied correct certs from current cossacklabs/mariadb-ssl:10.3-1 image and placed here. Otherwise acra will deny certs in OCSP checks due to mismatch serial in index.txt and current mysql.crt

Checklist

Copy link
Contributor

@Zhaars Zhaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lagovas Lagovas merged commit 492568a into master Sep 28, 2022
@Lagovas Lagovas deleted the lagovas/583-extend-returning-statement branch September 28, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants