Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling null values for postgresql in binary mode #593

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Oct 12, 2022

Previously we missed the logic of handling NULL values which should be encoded differently than empty strings. We encoded them as empty strings instead of placing -1 value according to wire protocol
This should fix #591.

Checklist

@Lagovas Lagovas requested a review from Zhaars October 12, 2022 23:47
@Lagovas Lagovas merged commit 91442df into master Oct 13, 2022
@Lagovas Lagovas deleted the lagovas/591-fix-handling-null-values branch October 13, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Acra replaces null values by an empty string when using prepared statements
2 participants