Renew info about TLS in http api #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added info about default true for http_api_tls_transport_enable flag
Fixed flag description
Lagovas
reviewed
Jan 26, 2023
tests/test.py
Outdated
| @@ -657,7 +657,12 @@ def test_clearing(self): | |||
| # execute any query for loading key by acra | |||
| result = self.engine1.execute(sa.select([1]).limit(1)) | |||
| result.fetchone() | |||
| with urlopen('http://localhost:{}/resetKeyStorage'.format(self.ACRASERVER_PORT + 1)) as response: | |||
| import ssl | |||
There was a problem hiding this comment.
lets move this import to the top of the file where all imports should be)
and lets add check_hostname for SSL to be stricter as we do it for asyncpg executor - https://github.com/cossacklabs/acra/blob/master/tests/base.py#L1198
Fixed after review
Lagovas
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added info about setting default true value for the
http_api_tls_transport_enableflag. Update tests to use HTTP API with tls.Checklist
with new changes