Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings #100

Merged
merged 11 commits into from
Nov 16, 2017
Merged

fix warnings #100

merged 11 commits into from
Nov 16, 2017

Conversation

Lagovas
Copy link
Contributor

@Lagovas Lagovas commented Nov 16, 2017

  • added explicit type conversations
  • checked comparison of signed/unsigned numbers and added explicit type conversations too
  • used #define UNUSED(expr) (void)(expr) to mark variables as unused
  • marked function params as void to fix warning: function declaration isn't a prototype
    Fix warnings in C-example #78
    p.s. try to compile hermes + examples again (make clean examples all) and tell which warnings still remain in Fix warnings in C-example #78

@Lagovas Lagovas requested a review from vixentael November 16, 2017 11:42
@vixentael
Copy link
Contributor

no previous warnings left.

however, I found error message while compiling mid_hermes_ll client, and fixed it.

cd docs/examples/c/mid_hermes_low_level && make
cc -g  ./obj/commands.o  ./obj/credential_store.o  ./obj/data_store.o  ./obj/key_store.o  ./obj/main.o  ./obj/base64.o  ./obj/utils.o -L../../../../build -lsoter -lhermes_mid_hermes_ll -lthemis -o hermes_client_ll
Undefined symbols for architecture x86_64:
  "_cst_time_memcmp", referenced from:
      _mid_hermes_ll_buffer_is_equal in libhermes_mid_hermes_ll.a(mid_hermes_ll_buffer.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [all] Error 1

circle.yml Outdated
@@ -4,16 +4,17 @@ machine:
# gopath directories below
TEMP_GOPATH: ${HOME}/temp_gopath
GOPATH: $TEMP_GOPATH:$GOPATH
STRICT_CFLAGS: "-Wall -Wextra -Wstrict-aliasing -fstrict-aliasing -pedantic -fno-common -Wno-unused-result -fno-common -fwrapv -Wstrict-prototypes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈

@Lagovas Lagovas merged commit 81fad1c into master Nov 16, 2017
@Lagovas Lagovas mentioned this pull request Nov 16, 2017
@Lagovas Lagovas deleted the lagovas/fix-warnings branch November 23, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants