add transport to gohermes and use secure session wrapper from hermes-core #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core update example client
vixentael
reviewed
Nov 2, 2017
gohermes/transport.h
Outdated
| // along with Hermes-core. If not, see <http://www.gnu.org/licenses/>. | ||
| // | ||
| // | ||
| #ifndef GO_MID_HERMES_H |
There was a problem hiding this comment.
are you sure that this is correct define name?
There was a problem hiding this comment.
I added GO_ prefix because MID_HERMES_H already used in hermes-core (https://github.com/cossacklabs/hermes-core/blob/master/include/hermes/mid_hermes/mid_hermes.h) and compiler doesn't include second time
There was a problem hiding this comment.
oh, yes. better if it would GO_TRANSPORT_H instead GO_MID_HERMES_H
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropped custom transport implementation of transport from gohermes, added
Transportinterface (that looks likehm_rpc_transport_tin hermes-core) which expect golang wrapper of HermesTransport and should be implemented by clientadded HermesTransport that used as adapter between user's transport implementation and C transport interface (hm_rpc_transport) expected by midhermes
also i have updated example that uses updated client with template of config file to avoid passing repeated a lot of params in examples