Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyArg_ParseTupleAndKeywords
doesn't supporty#
format in python2 (https://docs.python.org/2/c-api/arg.html) so I replaced it withs#
that works on python2/3Py_BuildValue
doesn't supporty#
too ands#
format will not work on python3 because it will try convert raw bytes to utf-8, so I replaced it with PyBytes usage that works on python2/3 (https://docs.python.org/3/howto/cporting.html#str-unicode-unification)plus replaced
PyObject_CallMethod
withPyObject_CallMethodObjArgs
which takesPyObject
fromPyBytes
and works similarly on py2/3