Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS KMS support info #255

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Added AWS KMS support info #255

merged 4 commits into from
Aug 1, 2022

Conversation

Zhaars
Copy link
Contributor

@Zhaars Zhaars commented Jul 12, 2022

Added basic information about the new Acra-supported flags and KMS-related configuration file format.

I think this PR should be marked as a draft until we extend all our Acra tools with supporting KMS for Acra Master Key loading as well.

Added basic info with KMS
@Zhaars Zhaars requested review from vixentael and Lagovas July 12, 2022 14:37
Co-authored-by: vixentael <vixentael@users.noreply.github.com>
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Distribute KMS cli flags across tools documentation
@Zhaars Zhaars marked this pull request as ready for review July 20, 2022 14:24
@Zhaars Zhaars requested a review from vixentael July 20, 2022 14:24
@vixentael vixentael added the acra Acra database encryption suite label Jul 20, 2022
@Zhaars
Copy link
Contributor Author

Zhaars commented Jul 20, 2022

Still need to add a similar section to the log-verifier tools when we add corresponding functionality.

Added KMS section to acra-log-verifier
@vixentael
Copy link
Contributor

what are we waiting here? @ZhmakaAS @Lagovas

@Lagovas
Copy link
Contributor

Lagovas commented Jul 27, 2022

what are we waiting here? @ZhmakaAS @Lagovas

merging cossacklabs/acra#554. But #554 ready for merging too) If I haven't forgotten anything.

@vixentael
Copy link
Contributor

lets merge then 😏

@Zhaars Zhaars merged commit df90ad8 into master Aug 1, 2022
@Zhaars Zhaars deleted the zhars/add_aws_kms_support branch August 1, 2022 11:47
Zhaars added a commit that referenced this pull request Aug 1, 2022
* mark secure session and connector as deprecated (#257)
* Added AWS KMS support info (#255)
Zhaars added a commit that referenced this pull request Aug 3, 2022
* mark secure session and connector as deprecated
remove extra paragraph about connector to simplify understanding data flow
* deprecate SS on GDPR page
* Added AWS KMS support info (#255)
Zhaars added a commit that referenced this pull request Aug 29, 2022
* mark secure session and connector as deprecated (#257)
* mark secure session and connector as deprecated
* remove extra paragraph about connector to simplify understanding data flow
* deprecate SS on GDPR page
*Added AWS KMS support info (#255)
*Added keystore_encryption_type flag definition
*Add description for TLS related flags for redis
*Added HashiCorp Consul configuration block details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acra Acra database encryption suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants