-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythemis: introduce pyproject.toml
#1006
Merged
G1gg1L3s
merged 5 commits into
cossacklabs:pre-release/0.15.0
from
G1gg1L3s:pythemis-pyproject-toml
Jun 19, 2023
+56
−1
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a2f777e
pythemis: Add pyproject.toml
G1gg1L3s fe9ac5a
makefile: Use pyproject.toml for installing pythemis
G1gg1L3s cc4ad60
pythemis: Update classifiers to Python3.6+
G1gg1L3s 67fe7e4
pythemis: Extend range of supported py versions
G1gg1L3s 0c50f66
Update changelog
G1gg1L3s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
[build-system] | ||
requires = ["setuptools"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "pythemis" | ||
version = "0.14.0" | ||
authors = [{ name = "CossackLabs", email = "dev@cossacklabs.com" }] | ||
description = "Themis is multi-platform library with a high-level and easy-to-use cryptographic toolkit for data protection" | ||
readme = "README.md" | ||
requires-python = ">=3.2" | ||
license = { file = "LICENSE" } | ||
dependencies = ["six", "enum34; python_version<'3.4'"] | ||
Lagovas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
classifiers = [ | ||
"Intended Audience :: Developers", | ||
"License :: OSI Approved :: Apache Software License", | ||
"Natural Language :: English", | ||
"Operating System :: MacOS :: MacOS X", | ||
"Operating System :: POSIX", | ||
"Operating System :: POSIX :: BSD", | ||
"Operating System :: POSIX :: Linux", | ||
"Programming Language :: Python", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.2", | ||
"Programming Language :: Python :: 3.3", | ||
"Programming Language :: Python :: 3.4", | ||
"Programming Language :: Python :: 3.5", | ||
"Programming Language :: Python :: 3.6", | ||
"Programming Language :: Python :: 3.7", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: Implementation :: CPython", | ||
"Programming Language :: Python :: Implementation :: PyPy", | ||
] | ||
|
||
[tool.setuptools] | ||
packages = ["pythemis"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with which version of pip3 it works? if it doesn't work with pip version from our supported distros (centos 7/8, last 3 versions of ubuntu/debian), so we should add here
pip3 install -U pip
to update system version pip to newerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it requires additional testing, preferably not manual as I did. But I guess for now we can add this command just to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking, maybe we should add that command to the
prepare_tests_all
? Updating pip each time pythemis_install is called doesn't sound good to me. For example, maybe there are reasons why users don't want to update pip.As I understand, only we use
prepare_tests_all
in our testing environments, so putting this command there should prevent problems with pip on our test machines. At the same time, if users, who install pythemis from the sources, will have to fix their environments in controlled way, if something goes wrong.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, better if we will add it in our own test environment. but starting installation via pip we should be sure that this approach supported by all supported OS, because approach with setup.py works for all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, another thought came to mind. The new pip versions (for example, in debian bookworm) don't want to install packages globally, so we will have to fix something (use virtual environments, pipx, etc). So, maybe it is better to postpone the change and fix only if it breaks?
Currently, it seems like a small change but it requires extensive testing on all our platforms.