Remove pythemis_{make,install}_wheel #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After stable was merged into master, wheel generation is no longer needed since `make pythemis_install` just works when virtualenv is activated. Also, previous command for .whl generation is no longer working, would need some changes to make it work with pyproject.toml
iamnotacake
requested review from
vixentael,
ilammy,
shadinua and
Lagovas
as code owners
Lagovas
approved these changes
Dec 9, 2023
vixentael
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After stable was merged into master, wheel generation is no longer needed since
make pythemis_installjust works when virtualenv is activated.Also, previous command for .whl generation is no longer working, would need some changes to make it work with pyproject.toml
Checklist
Benchmark results are attached (if applicable)Public API has proper documentationExample projects and code samples are up-to-date (in case of API changes)