Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate auth errors for invalid UserId/credentials types #114

Merged
merged 1 commit into from
Jan 31, 2025
Merged

feat: separate auth errors for invalid UserId/credentials types #114

merged 1 commit into from
Jan 31, 2025

Conversation

m4tx
Copy link
Member

@m4tx m4tx commented Jan 31, 2025 •
edited
Loading

Followup to the discussion: #111 (comment)

@m4tx m4tx requested review from seqre and Iipin January 31, 2025 13:18
@m4tx m4tx mentioned this pull request Jan 31, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot/src/auth/db.rs 60.00% 2 Missing ⚠️
Flag Coverage Δ
rust 84.93% <60.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot/src/auth.rs 93.00% <ø> (-0.80%) ⬇️
cot/src/auth/db.rs 76.89% <60.00%> (-0.45%) ⬇️

@m4tx m4tx merged commit 6720a9e into master Jan 31, 2025
24 of 25 checks passed
@m4tx m4tx deleted the new-auth-errors branch January 31, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seqre seqre seqre approved these changes

@Iipin Iipin Awaiting requested review from Iipin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4tx @seqre